carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
271 stars 156 forks source link

Expressive theme mixin "use-carbon-productive-tokens" does not work without CSS custom properties enabled #3698

Closed jeffchew closed 3 years ago

jeffchew commented 4 years ago

Detailed description

Describe in detail the issue you're having.

With CSS static builds, non-CSS custom properties tokens appear to be overwritten by the expressive token values when using use-carbon-productive-tokens. The way around this is to have enable-css-custom-properties set as true, but we would hopefully find a way for the theme to work without enabling CSS custom properties.

Is this a feature request (new component, new icon), a bug, or a general issue?

Bug

Is this issue related to a specific component?

Expressive Theme

What did you expect to happen? What happened instead? What would you like to see changed?

Expressive theme mixin use-carbon-productive-tokens works in production builds without the use of CSS Custom Properties in Carbon

Steps to reproduce the issue

  1. Go to https://github.com/carbon-design-system/ibm-dotcom-library-nextjs-test
  2. Run yarn upgrade then yarn dev
  3. See that the local deployment works by viewing the mega menu (rendering with the productive tokens)
  4. Run yarn build-export
  5. Deploy ./out/index.html on a local server
  6. See that the local static build has expressive tokens applied to the mega menu

Additional information

Local dev (yarn dev):

Screen Shot 2020-08-24 at 3 07 05 PM

Static deploy (yarn build-static):

Screen Shot 2020-08-24 at 3 05 44 PM
RobertaJHahn commented 4 years ago

Added to Aug 31 engineering meeting agenda.

jeffchew commented 4 years ago

@RobertaJHahn Pushing this one out further.

RobertaJHahn commented 3 years ago

Closing. There have not been any complaints from Adopter teams. Carbon will be adopting custom properties by default. No need for this feature.