search

carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
269 stars 156 forks source link

Mobile Footer Adds Extra Space #410

Closed jeffchew closed 5 years ago

jeffchew commented 5 years ago

james-dow created the following on Sep 10:

Detailed description

The footer when on mobile and positioned at the bottom of the screen will leave a large gap of whitespace. I think this is happening because the accordion content is pushing the page down further while invisible. This may actually be more of a bug on Carbon's Accordion than it is on our footer. Until we can get that fixed I think a simple solution is to add overflow: hidden; to the Accordion's content area. I haven't seen any negative repercussion of this yet.

Steps to reproduce the issue

  1. Go to https://ibmdotcom-react.netlify.com/?path=/story/dotcom-shell--default
  2. Resize window to mobile view
  3. Scroll to the bottom of the page.

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1637

jeffchew commented 5 years ago

@photodow wasn't this fixed already?

photodow commented 5 years ago

Yeah, did we create a duplicate issue in digital-design too? It looks like it can be closed.

Here is the one we worked off of https://github.com/carbon-design-system/ibm-dotcom-library/issues/170