search

carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
264 stars 157 forks source link

Centralize the IBM Logo for IBM.com #411

Closed jeffchew closed 4 years ago

jeffchew commented 4 years ago

james-dow created the following on Sep 10:

Detailed description

Not sure if this is necessarily a bug, but maybe more of a technical debt item that I wanted to make sure we didn't forget.

Ultimately we need to figure out how to best leverage and unify the IBM logo across IBM.com. Especially for our own components like the masthead, and footer. Right now we are using two different IBM logos for those components. When consolidating the logos, the banding issue must also be resolved.

Additional Information

Currently, the SVG logo is showing banding issue on some monitors. It depends on the monitor's DPI, but here is a screen capture:

Screen Shot 2019-10-04 at 6.26.04 PM.png

Two logos

Questions

Acceptance Criteria

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1639

jeffchew commented 4 years ago

@photodow why was this pulled into this sprint? We didn't triage this or set a priority for this yet.

cc: @RobertaJHahn

photodow commented 4 years ago

@jeffchew sorry if I did something out of order. I was told to cherry-pick items that could be done quickly. If that's not true, then I can return it to be triaged, no problem.

jeffchew commented 4 years ago

Oh ok got it, didn't realize you were cherry-picking this, but I guess we need to set parameters on what the max size of a cherry-picked item should be. I was thinking a 1 (this was sized as a 2), but we should probably define that going forward.

cc: @RobertaJHahn @ljcarot @wonilsuhibm

RobertaJHahn commented 4 years ago

I have added this topic to the Huddle meeting agenda today. Might also be good to get feedback from team members to refine the process.

@jeffchew @photodow @ljcarot @wonilsuhibm

jeffchew commented 4 years ago

Thank you @RobertaJHahn , I have already made updates to the DDS support documentation based on various feedback already in the past couple of weeks: https://ibm.ent.box.com/notes/506284098346

We can discuss in huddle.

RobertaJHahn commented 4 years ago

Additional comments from issue 165

Kenny Lam: @wonilsuhibm Do you have a better asset you can provide?

Wonil: @kennylam I'm suspecting that it might be coming from SVG rendering, which tends to be too sharp with little or no anti-aliasing.

I'm attaching a zip file with different sizes. Any chance we can test them out so that we can find the right resolution?

ibm--8bar-logo--png--sizes.zip