carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
269 stars 156 forks source link

lint-stage "yarn test" failing even though running manually passes #439

Closed jeffchew closed 5 years ago

jeffchew commented 5 years ago

Jeff-Chew created the following on Sep 16:

Detailed description

When running a commit, yarn test stage seems to fail, even though if running manually all tests are passing.

yarn test has been temporarily removed until this can be resolved.

Steps to reproduce the issue

  1. Add back yarn test to .lintstagerc file
  2. Run commit
  3. See that pre-commit fails

Additional information

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1701

jeffchew commented 5 years ago

On Sep 24, Anna-Wen commented: The errors coming out of the tests are indeed what is causing the pre-commit yarn test script to fail. There are some long threads of others with the same issue and looks like React 16.9.0 alpha could solve it - but we can silence the act() errors for now: https://github.com/facebook/react/issues/14769#issuecomment-514589856

jeffchew commented 5 years ago

On Sep 24, Jeff-Chew commented: @Anna-Wen thanks for looking into this! Sure, I'm fine with silencing the errors for now.