Environment variables not working in Netlify output - Githubissues

carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM

https://www.ibm.com/standards/carbon/

Apache License 2.0

269 stars 156 forks source link

Environment variables not working in Netlify output #440

Closed jeffchew closed 5 years ago

jeffchew commented 5 years ago

Jeff-Chew created the following on Sep 16:

Detailed description

Even if environment variables are set in the Netlfiy configuration, they are not being picked up in the Storybook output.

Steps to reproduce the issue

Go to https://deploy-preview-78--ibmdotcom-patterns-react-experimental.netlify.com
See that experimental feature LeadSpace is not visible even though LEADSPACE variable is set to true

Additional information

Log into Netlify using ibmdotcom-bot
Settings for patterns-react in: https://app.netlify.com/sites/ibmdotcom-patterns-react-experimental/settings/deploys#continuous-deployment

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1703

jeffchew commented 5 years ago

On Sep 16, Jeff-Chew commented: Fix has been applied, the environment variables have to be set a certain way for Storybook to pick up. Documentation has been added here:

https://ibm.ent.box.com/notes/497580921328