carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
264 stars 157 forks source link

Design kit: Update symbol IDs #456

Closed jeffchew closed 4 years ago

jeffchew commented 4 years ago

Olivia-Flory created the following on Sep 17:

Change all the symbol IDs in the Digital Design expressive (white theme) kit to not match Carbon white kit IDs.

Notes We found the symbol IDs in the white design kit match the symbol IDs in Carbon. This could potentially cause some problems down the line because each symbol is meant to have a unique ID so Sketch doesn't get confused and mix up the symbols between documents.

The symbol IDs needs to be updated before releasing to the adopters because once the ID is changed, the symbol would break it's connection in another document and it would be a terrible experience for our adopters to have to reconnect every symbol they use.

Solution: I will duplicate all the symbols, then delete the original ones and rename all the symbols with the Rename it plug in to remove all the "copy"s

Acceptance criteria

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1722

jeffchew commented 4 years ago

On Sep 20, Olivia-Flory commented: @Wonil-Suh1 I will likely need to bump this estimate up to a 2. Realizing that duplicating the symbols is a great idea, but it means i have to go in and update all the nested symbols to the duplicated master, which will take me a bit longer.

I will keep track of my time to make sure it's at the right size for the amount of work in the end.