[Design kit]: add footer - Githubissues

carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM

https://www.ibm.com/standards/carbon/

Apache License 2.0

264 stars 157 forks source link

[Design kit]: add footer #490

Closed jeffchew closed 4 years ago

jeffchew commented 4 years ago

Olivia-Flory created the following on Sep 26:

User story

As a designer, I need access to visual design symbols of the new footer, so I can align my designs to the new standard.

Notes

Designers need to use the new footer in their designs so they don't confuse the developers with the northstar footer
we need to include the footer in a design kit

Outstanding questions

should it be included in the Expressive design kit?
should the footer be in a IBM.com library design kit?
is any of it customizable?

Tasks

[x] identify which pieces of the footer are customizable
[x] figure out symbol structure
[x] cover all breakpoints
[x] cover all variations
[x] add symbols to design kit

Acceptance criteria

[x] Symbols match design and code specifications
[ ] Design reviewed by Wonil
[ ] Design approved Wonil

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1778

oliviaflory commented 4 years ago

@wonilsuhibm I have all the footer versions in this file: https://ibm.ent.box.com/folder/90951802351

Things we need to discuss:

size of logo at different breakpoints
logo margin at different breakpoints
locale selector
- how it's placed on the columns
- should we include it or hide it until the locale selector is ready in code?

wonilsuhibm commented 4 years ago

@oliviaflory was our conversation the other day enough to answer your questions?

The locale selector should be hidden until it becomes available.