Closed shixiedesign closed 3 years ago
If the fix is just in token values, #5545 would be resolved by this issue too.
@shixiedesign setting the second parameter to true
in @include carbon--type-style('expressive-heading-05', true);
solves the issue and sets font size scaling.
As for Lead Space Block, it does look like it is using expressive-heading-05
from content-block
Not sure why it doesn't specify the token in the console and instead outputs the actual value.
Probelm
$expressive-heading-03
should be 24px atmax
breakpoint. Currently card title showing 20px atmax
in Card component and all its variations. This suggest there are errors in the token's values ❌.$expressive-heading-05
should be 60px atmax
breakpoint. As seen in React experimental: Lead space with Search, the value is wrong at 32px. And in Lead space block, which should use this token for sub-headline, the value is hard coded 😱.Correct the values of
$expressive-heading-03
and$expressive-heading-05
Reference source: https://carbondesignsystem.com/guidelines/typography/expressive#fluid-type-sets
$expressive-heading-03
max
xlg—sm
$expressive-heading-05
max
xlg
lg
md
sm