carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
264 stars 157 forks source link

[Masthead]: Provide local/globalization support to Platform Name and URL #6178

Closed proeung closed 3 years ago

proeung commented 3 years ago

The problem

Screen_Shot_2021-05-25_at_11_12_26_AM

<dds-cloud-masthead-container
  platform="Cloud"
  data-endpoint="/common/carbon-for-ibm-dotcom/translations/cloud-masthead/jsononly"
  platform-url="https://www.ibm.com/cloud"
></dds-cloud-masthead-container>

The solution

jeffchew commented 3 years ago

Does the platform name need to be translated if it's an IBM product name?

proeung commented 3 years ago

@jeffchew From what I've seen so far, the platform name looks to be translated for non-English speaking countries, please see below for the list of pages that are translating the word "Cloud".

I'm not sure if this is the standard, however, I think it's still important to expose the platform-url string in the API endpoint so that each local can put in their proper homepage link.

Screen_Shot_2021-05-27_at_10_54_47_AM

RobertaJHahn commented 3 years ago

Will be added to the 6/7 engineering refinement meeting agenda.

RobertaJHahn commented 3 years ago

HC has a work around until this is ready. Moving to the July 27 release.

proeung commented 3 years ago

@RobertaJHahn Thanks! Looking forward to seeing the long term solution for this issue in the July 27 release.