search

carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
267 stars 157 forks source link

[Masthead]: Masthead missing top padding to prevent overlay with content components - DPO Consulting #6270

Closed annawen1 closed 2 years ago

annawen1 commented 3 years ago

Engineering info:

Detailed description

Describe in detail the issue you're having.

There is padding-top: 3rem applied to the DotcomShell component to prevent the overlap of the masthead and another component on the page (ie. Leadspace). However if adopters use the masthead independently of the DotcomShell, we see the overlap issue occurring.

Solution would be to apply the padding-top to the masthead component instead of DotcomShell.

Additional information

Screen Shot 2021-06-01 at 5 24 36 PM

Issue seen on zStore application: image (9)

proeung commented 3 years ago

@annawen1 Thanks for opening this ticket!

@huntermacd FYI.

stale[bot] commented 3 years ago

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

shixiedesign commented 3 years ago

I believe we still need this - adding adopter support as this is a recurring issue.

jeffchew commented 2 years ago

Might be related to https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/7643