Closed paatsinsuwan closed 2 years ago
@paatsinsuwan the link to video in Box does not work for me.
@ljcarot I've updated the link to the video and also here https://ibm.box.com/v/modal-flickering-bug.
@proeung adding @IgnacioBecerra to the issue. He mentioned he may know the cause of this issue.
@paatsinsuwan The video seems to be unavailable, but this issue might be fixed in v1.30.0-rc1
. Could you test with the new release? If it's not fixed I might have another solution for this. Let me know!
@IgnacioBecerra I just ran yarn update-canary
and I'm still seeing the flash.
https://user-images.githubusercontent.com/910956/150871473-1921ac41-6fc7-4403-9391-76628fccd6c7.mov
@paatsinsuwan Would you be able to share your repo? I can't seem to replicate the error on my local machine.
@paatsinsuwan I'm also unable to replicate based on the steps you provided in the issue description. Is this issue still occuring with the latest changes to the template repo?
@IgnacioBecerra @andy-blum Confirm that the issue is no-longer happening. But I do have to re-clone the template to get it to work as expected. Thank you both.
@IgnacioBecerra @andy-blum It looks like the same issue happened in component(footer-container), would you please help to check? import "@carbon/ibmdotcom-web-components/es/components/footer/footer-container.js"
Issue still occurs in FF as of v1.31.1
.
@paatsinsuwan Is there a site where this is happening you can share? A number of us have tried to reproduce this and cannot.
@kennylam I can still see it with the latest version of this template. https://github.com/carbon-design-system/carbon-for-ibm-dotcom-web-components-template
Got it, we'll take a look. Thanks!
@paatsinsuwan Can you link something live other than the github repo? We've looked at that template following the steps to reproduce in the issue description and have not been able to reproduce.
@andy-blum have you tried in FF? I'm pretty sure you'll see it. It was reported on this page https://www.ibm.com/lets-create/ until the agency apply a local version of fix to the code.
dds-locale-modal-composite { display: none; &[open] { display: contents; } }
@paatsinsuwan Yes, we tried firefox.
Here's what I did:
Using the above process, I was unable to replicate the flashing issue, and @kennylam @ariellalgilmore and @annawen1 also confirmed they were unable to see the flash.
@andy-blum Hey man, if you confirmed it fixed, I'll take it.
Thanks @andy-blum!
Engineering info:
Description
Locale modal is flashing when refresh the page while it should not
video
Component(s) impacted
dotcom-shell locale-modal
Browser
Firefox, Chrome
Carbon for IBM.com version
^1.14.1
Severity
Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.
Application/website
NDA
Package
@carbon/ibmdotcom-web-components
CodeSandbox example
https://github.com/carbon-design-system/carbon-for-ibm-dotcom-web-components-template
Steps to reproduce the issue (if applicable)
Clone template https://github.com/carbon-design-system/carbon-for-ibm-dotcom-web-components-template Run
yarn start
(might have to fiddle with webpack-dev-config.js) After the page load, hit refresh and waitRelease date (if applicable)
No response
Code of Conduct