carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
268 stars 156 forks source link

[Structured list] Web Component: enhancement and new variant #8388

Closed ibmdotcom-bot closed 2 years ago

ibmdotcom-bot commented 2 years ago

Engineering info:


User Story

As a [user role below]: Carbon for ibm.com developer

I need to: create/change the Structured list

so that I can: provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

1. Structured list enhancement

2. Structured list with row headers (vertical)

New variant of current structured list

3. 8 columns

Not sure if this is an enhancement or new, I think structured list can already span 8 columns? Screen Shot 2022-02-25 at 11 48 46 AM

Additional Information

Acceptance criteria

kennylam commented 2 years ago

Hey team! Please add your planning poker estimate with ZenHub @andy-blum @mwanberg @jkaeser

kennylam commented 2 years ago

Please add your planning poker estimate with ZenHub @proeung

proeung commented 2 years ago

@EAVilleda @dratzenboeck-ibm Just a heads up, this component is scheduled to be worked on for our current sprint (05). I think it'll be helpful if you both can provide some examples of how you're looking to structure this component on the AEM editorial side so that we won't run into issues during the integration process. Managing tables can be tricky, therefore I think it'll be helpful to see if you guys are managing them as defined node structure or free form in the WYSIWYG.

dratzenboeck-ibm commented 2 years ago

@proeung Our plan is using the AEM rich text editor for table editing. So we are not building a component where you can add table rows and cells as subcomponents, but where the author can basically edit the HTML with a table editor and the output should be the final HTML. This means out of the box the markup would result in something like the table here https://www.aemcomponents.dev/content/core-components-examples/library/page-authoring/text.html#title-36ac9ed382 . If we need different markup we probably will need to customize the AEM rich text editor.

andy-blum commented 2 years ago

@dratzenboeck-ibm does your rich text editor limit what HTML is valid to things like <table> or will you be able to add in web components?

andy-blum commented 2 years ago

Also, is this how your team is planning to author the similar pricing tables components?

https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/8389

dratzenboeck-ibm commented 2 years ago

@andy-blum As said the <table> markup is the default output of the rich text table editor. If we need web components we will have to put in effort to change the output markup of the RTE. Regarding pricing tables components I haven't seen any designs yet. I thought a pricing table would be a widget that is filled with content from an API instead of manually authored content. But yes generally I would say if we want the author to build a table himself it should be by using the rich text editor. We don't plan to build another table variation where we have rows / cells as separate components.

proeung commented 2 years ago

Moving the React Wrapper portion of this component into a separate ticket (https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/8494) and leaving this one to just Web Components.