carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
269 stars 156 forks source link

Web Components: Video component not changing thumbnail to a custom image #8658

Closed guilhermealima closed 2 years ago

guilhermealima commented 2 years ago

Engineering info:


Description

When trying to add a custom thumbnail to an inline video using the dds-video-player-container component, the video kept pulling the default thumbnail image from MediaCenter, even using the thumbnail-url property as indicated by the Carbon documentation.

Component(s) impacted

dds-video-player-container

Browser

Chrome

Carbon for IBM.com version

1.16.1

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

https://www.ibm.com/resources/guides/hybrid-cloud-strategy/

Package

@carbon/ibmdotcom-web-components

CodeSandbox example

https://codesandbox.io/s/video-thumbnail-bug-p7zyhc

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

oliviaflory commented 2 years ago

This PR is hardcoding the Kaltura video thumbnail and needs to be undone to allow for custom thumbnails https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/7914/files#diff-c16cc0206fb8b5202bfa8ddd7900037a71fb8b30235347e4c33ece727f8d8860R94-R97