search

carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
268 stars 156 forks source link

[lightbox-media-viewer - with carousel]: QA: Trap within the Light box modal dialog #8910

Closed Gopi916 closed 1 year ago

Gopi916 commented 2 years ago

Engineering info:

Description

Page element: Light box modal

Issue Description:

  1. Screen reader focus is not trapped within the modal dialog.
  2. When the focus is not trapped, there are couple of buttons that are identified by the screen reader just before and after the dialog with the label "start" and "end".

Expected:

  1. Screen reader focus is expected to be trapped within the dialog in up/down arrow key along with tab/shift tab key
  2. The visually hidden buttons should be hidden from SR as well

User Impact: When the screen reader focus is not restricted within the modal dialog, it also identifies parent page content that disorients screen reader users.

Component(s) impacted

lightbox-media-viewer - with carousel

Browser

Firefox

Carbon for IBM.com version

canary

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

Carbon for IBM.com

Package

@carbon/ibmdotcom-web-components

CodeSandbox example

https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8757/iframe.html?id=components-lightbox-media-viewer--with-carousel

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

andy-blum commented 2 years ago

The test link is the deploy preview from #8757 but the focus issues were addressed in #9004.

The fixes should also be available in canary

stale[bot] commented 2 years ago

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

oliviaflory commented 2 years ago

Not stale, issue in Review process

proeung commented 1 year ago

Closing this issue based on @andy-blum's comment (https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/8910#issuecomment-1188302183). Feel free to re-open this issue if the bug still persists.