carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
268 stars 156 forks source link

[Background Media]: QA: Focus is not visible on 'Play' button #8995

Closed Gopi916 closed 2 years ago

Gopi916 commented 2 years ago

Engineering info:


Description

Page Element: Play button

Issue Description: Keyboard focus is not visible clearly on the Play button

Expected: Keyboard focus should be visible clearly on the button.

User Impact: When focus indicator for the page element is not clear, the user would have difficulty in identifying the currently focused element. this impacts Keyboard only users and people who with low vision

Component(s) impacted

Background Media

Browser

Firefox

Carbon for IBM.com version

v1.35.0-rc.0

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

Carbon for IBM.com

Package

@carbon/ibmdotcom-react

CodeSandbox example

https://carbon-design-system.github.io/carbon-for-ibm-dotcom/next/web-components-react

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

RichKummer commented 2 years ago

The Background media design specs do not have a focus state to work off of. Putting together a design exploration story to solve for the contrast issue on the focus state.

RichKummer commented 2 years ago

@andy-blum @proeung - I've updated the Background media design specs to define the focus state for the White theme. In the PDF, the relevant page is 13 and the info is also screencapped here:

Screen Shot 2022-06-23 at 3 35 17 PM

If you have any questions, please let me know!

proeung commented 2 years ago

@RichKummer Thanks for updating the specs! We'll go ahead and move this issue into this sprint, now that we have the proper specs from design.

gopinathan-n commented 2 years ago

@IgnacioBecerra Double check change log.

IgnacioBecerra commented 2 years ago

@Gopi916 Staging storybook was slightly outdated -- the fix should be showing on staging now.