carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
268 stars 156 forks source link

[Background Media]: QA: Tooltip of the play button is not getting dismissed with esc key. #8996

Closed Gopi916 closed 1 year ago

Gopi916 commented 2 years ago

Engineering info:


Description

Page Element: Tooltip of Play button

Issue Description: Tooltip of the play button is not getting dismissed with esc key.

Expected: Tooltip of the play button should get dismissed with esc key.

User Impact: When the additional content in the page is not getting dismissable by the esc key, user may find discomfort in accessing the web content.

Component(s) impacted

Background Media

Browser

Firefox

Carbon for IBM.com version

v1.35.0-rc.0

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

Carbon for IBM.com

Package

@carbon/ibmdotcom-react

CodeSandbox example

https://carbon-design-system.github.io/carbon-for-ibm-dotcom/next/web-components-react

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

andy-blum commented 2 years ago

@proeung

I'm not sure if this is actually a bug or not, and if it is, it probably needs fixed upstream.

The carbon-core tooltip documentation does specify that tooltips should be dismissed with esc is pressed, and that is the behavior in the live demo. However, the tooltip in carbon-web-components does not incorporate that behavior

andy-blum commented 2 years ago

For additional info/context: that tooltip is simply appearing/disappearing based on :hover and :focus selectors in the stylesheets, with no js involved at all, so this would likely require reworking in other locations as well such as the masthead with logo & tooltip

proeung commented 2 years ago

Related to https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/9158

proeung commented 2 years ago

Blocked by https://github.com/carbon-design-system/carbon-web-components/issues/980