carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
258 stars 155 forks source link

[CTA]: Expose dds-link-list-item-cta and dds-link-list-item-card-cta in the SB variant preview #9032

Open proeung opened 2 years ago

proeung commented 2 years ago

The problem

The solution

Application/website

AEM

Business priority

Low Priority = release date is not dependent on fix or not upcoming

What time frame would this ideally be needed by (if applicable)

No response

Examples

No response

Code of Conduct

proeung commented 2 years ago

@RichKummer I'd love to get your opinion on this improvement request from a design perspective.

cc: @ariellalgilmore

kennylam commented 2 years ago

@proeung Those two components you mentioned simply extend features already provided by CTA. I don't believe there is an instance for them to ever be used on their own - they are more internal components. For instance:

I do agree that the naming of them is a bit confusing. We could probably rename these, or at least mention them and their intended usage in documentation to avoid any confusion. But in any case, showcasing them in Storybook would probably only add to the confusion since they are not intended to be used in the same manner as the other CTA variations (and that may be changing too, we're in the process of auditing how these components are going to be offered).

proeung commented 2 years ago

@kennylam I think the confusion is largely due to the fact that the existing Link List component preview and docs don't have a reference to dds-link-list-item-cta. Just a bit of context, AEM is adopting the CTA component in order to leverage the CTA type that automatically renders the icon based on the selection made by the Content Editors are building.

For instance, they're assembling a layout where there's a <dds-card-cta> on top and <dds-link-list> below (see attached). Overall, I think this issue opens up a discussion that's long overdue about the usage of the regular <dds-card-footer> vs one with CTA ability and how to best document these features for adopters. Happy to jump on a call and provide detail on what we're seeing and how to best clean up the SB docs to make it clear to folks.

Screen Shot 2022-07-06 at 4 51 58 PM https://codesandbox.io/s/sad-euler-vowt9f?file=/index.html

stale[bot] commented 1 year ago

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.