carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
266 stars 157 forks source link

[Pricing table]: CTA wrong size #9394

Open oliviaflory opened 2 years ago

oliviaflory commented 2 years ago

Description

The CTA within the Pricing table header is a large type and container size than what is defined in the specs.

This throws off the hierarchy of the content.

Current Expressive button: 16px type; 48px container

Screen Shot 2022-09-19 at 8 49 50 AM

Expecting Productive button: 14px type; 40px container

Screen Shot 2022-09-19 at 8 51 48 AM

Component(s) impacted

Pricing table

Browser

Chrome

Carbon for IBM.com version

v1.23.0

Severity

Severity 4 = The problem is not visible to or noticeable to an average user. Affects minor functionality, no workaround needed.

Application/website

AEM / C4IBM

Package

@carbon/ibmdotcom-web-components, @carbon/ibmdotcom-styles

CodeSandbox example

https://carbon-design-system.github.io/carbon-for-ibm-dotcom/canary/web-components-experimental/?path=/story/components-pricing-table--default

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

oliviaflory commented 2 years ago

cc: @jwitkowski79 @andy-blum

stale[bot] commented 1 year ago

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

andy-blum commented 1 year ago

@oliviaflory is this still a problem?

oliviaflory commented 1 year ago

hey @andy-blum ! I believe so, looks like it's still the expressive button (16px type size) and I think Jen initially designed it with the default 14px type size.

I'm not sure which button this is using, maybe the Carbon for IBM.com CTA button which overrides the styles? But I'd expect the type hieararchy to remain the same throughout the table and use the Carbon WC default type size