carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
248 stars 150 forks source link

File uploader item: missing styling for invalid state #9726

Open CodeAdraas opened 1 year ago

CodeAdraas commented 1 year ago

Description

Hello, I'm using this package in combination with vite+vue.

When a file uploader item is in invalid state, styling does not appear e.g. the component it's red border, validity slots font styling and padding. Slots do however appear to function normally and the 'danger' icon is visible.

I checked the storybook docs and after fiddling around I came to the conclusion there are no styles when the file uploader item is in invalid state. See (amazing screenshots...) below.

issue-1 What the component in invalid state looks like in my environment (vite+vue)

issue-2 What it should look like (storybook docs)

issue-3 What it looks like on storybook docs when I manually remove 'invalid' attribute via devtools

As you can see, the styling on the last screenshot appears to be the same as in my own environment. For the codesandbox, I can't even reproduce an example because the file uploader item does not work in codesandbox :/

Component(s) impacted

BxFileUploaderItem

Browser

Microsoft Edge

Carbon Web Components version

v1.21.0

Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Application/website

https://web-components.carbondesignsystem.com/?path=/story/components-file-uploader--default

CodeSandbox example

https://codesandbox.io/s/nostalgic-star-kzmdgk

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

stale[bot] commented 1 year ago

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.