search

carbon-design-system / carbon-icons

SVG icon library for the Carbon Design System
https://www.carbondesignsystem.com/guidelines/iconography/library
Apache License 2.0
86 stars 53 forks source link

Do not suggest app.use(express.static('node_modules') #24

Closed alon24 closed 7 years ago

alon24 commented 7 years ago

in the readme and in the actual code (server.js) it says: app.use(express.static('node_modules'));

this should not be suggested or used, it should be:

  1. add task to copy icon file to public/svg
  2. use that file from public/svg
hellobrian commented 7 years ago

Thanks for pointing this out, and sorry if this caused any issues - I'm updating the docs now with your recommendation.

hellobrian commented 7 years ago

Also, feel free to leave comments on the PR that's up: https://github.com/carbon-design-system/carbon-icons/pull/25 , if there's anything else I should change I'd be happy to hear more of your feedback.