search

carbon-design-system / carbon-icons

SVG icon library for the Carbon Design System
https://www.carbondesignsystem.com/guidelines/iconography/library
Apache License 2.0
86 stars 53 forks source link

Some 9.0.0 icons are missing the 45 degree inside corner #71

Closed jackiwakin closed 6 years ago

jackiwakin commented 6 years ago

Detailed description

Describe in detail the issue you're having.

It would appear a few of the icons missed the 45 degree inside corners

Is this a feature request (new component, new icon), a bug, or a general issue?

bug

What version of the Carbon Design System are you using?

9.0.0

Additional information

screen shot 2018-06-06 at 11 11 47 am screen shot 2018-06-06 at 11 12 06 am screen shot 2018-06-06 at 11 12 50 am screen shot 2018-06-06 at 11 14 13 am
joshblack commented 6 years ago

cc @tay-aitken just to confirm if this is in the Sketch file, or not. Could easily be a mistake in our build step.

Also, just a heads up @jackiwakin make sure not to make any public references to that one project 👍

tay-aitken commented 6 years ago

Hi @jackiwakin! Thanks for bringing this to our attention. These have now been fixed. They will be updated in the next kit release in the design kit/library (which currently does not have an expected/planned release date) . @joshblack it it a breaking change to update these icons in the repo?

tay-aitken commented 6 years ago

Just a note: will not be updating the forum icon to have those corners as the library we inherited from does not follow that styling on that particular icon.

tay-aitken commented 6 years ago

Going to close this issue as the icons with the error have been fixed :)

tay-aitken commented 6 years ago

This was addressed in PR #76