carbon-design-system / carbon-icons

SVG icon library for the Carbon Design System
https://www.carbondesignsystem.com/guidelines/iconography/library
Apache License 2.0
85 stars 53 forks source link

Contribution: Deploy #83

Open emily827 opened 6 years ago

emily827 commented 6 years ago

The name of the icon is "deploy". It's going to be used when deploying code. The following .zip has the svg and an image of what it looks like. deploy.zip

asudoh commented 6 years ago

Thank you for bringing this up @emily827! Let's see if how many other Carbon users want this icon, and if our (or brand) designers agrees that the icon fits well in Carbon ecosystem. Meanwhile, you can use your custom icon in carbon-components-react's <Icon> component, by using a JSON data from SVG (XML) with a conversion, as <Icon>'s icon prop. Data format examples can be found at https://unpkg.com/carbon-icons@7.0.0/dist/carbon-icons.js. Thanks!

chrisconnors-ibm commented 6 years ago

Hi @emily827 - thanks for submitting this. There's a couple issues: Color. use plain black fill - colors will be applied in code later.

Stroke weight: for 16x16 icons in this style, stroke weight should be 1px

Alignment: as possible, make sure strong v and h elements and end points are aligned to the grid. Yes: image No: image

Avoid fractional sizes: Yes: image

No: image

You might find some of the execution guidance on http://design-system.stage1.mybluemix.net/your-product-on-ibm-cloud/service-providers/service-icon useful for additional clarification.

conradennis commented 5 years ago

a version of this icon that is compatible with the new IBM Design Language is available here: https://next.carbondesignsystem.com/guidelines/iconography/library in the sketch kit or as individual SVGs from the icon library

look for the "deploy-rules" icon. If that icon does not suit your need please resubmit your artwork redrawn at 32px on grid and we can continue the contribution process. more guidance on icon production can also be found here: https://www.ibm.com/design/language/elements/icons

mjabbink commented 4 years ago

@conradennis close?