search

carbon-design-system / carbon-platform

The "next" version of the Carbon Design System website, as a platform.
https://next.carbondesignsystem.com
Apache License 2.0
21 stars 5 forks source link

Back button from library detail to catalog not working #1316

Open alisonjoseph opened 2 years ago

alisonjoseph commented 2 years ago

Bug🐛: Filters should persist Page: Catalogs Browser: Chrome Suggestion: Filters should persist when a user wants to return to catalog filters should persist

Originally posted by @kingtraceyj in https://github.com/carbon-design-system/carbon-platform/discussions/1268#discussioncomment-3684473

doesn't seem to be working with a back button either and back button didn't work the first time. catalog back

andreancardona commented 2 years ago

Hey team! Please add your planning poker estimate with Zenhub @francinelucca @alisonjoseph

andreancardona commented 2 years ago

Please add your planning poker estimate with Zenhub @jdharvey-ibm

francinelucca commented 2 years ago

is the expected behavior that if you got to the asset detail from the catalog and then click on the catalog breadcrumb the previously selected filters will remain or that the previous filters will always remain regardless of where you are coming from?

mattrosno commented 2 years ago

This is working as designed. If you start here:

https://next.carbondesignsystem.com/assets/components?framework[]=react&maintainer[]=carbon&status[]=stable

And you go into a component page, that page doesn't know the preview page's query string.

image.png

That's a browser thing. If you click browser back, you can return to:

https://next.carbondesignsystem.com/assets/components?framework[]=react&maintainer[]=carbon&status[]=stable

This is one more justification for why the breadcrumb should be hierarchical where the breadcrumb for that page reads:

Carbon React v1.14.0
  - Assets
    - Accordion

If you want to go back to the preview page in whatever state you left it in, use the browser back button.

Catalogs and collections are shortcuts to assets that live in libraries. The asset breadcrumbs should reflect that.

@aagonzales @kingtraceyj @jeanservaas @aubrey-oneal I propose we close this issue as won't fix, and instead, update how our asset page breadcrumb works.

Additional justification: https://github.com/carbon-design-system/carbon-platform/issues/1329