search

carbon-design-system / carbon-platform

The "next" version of the Carbon Design System website, as a platform.
https://next.carbondesignsystem.com
Apache License 2.0
21 stars 5 forks source link

Update Framework icons on Library page #1318

Open alisonjoseph opened 2 years ago

alisonjoseph commented 2 years ago

Small shape icon for Vanilla JavaScript should be the same as the large one, just the JS without a box around it. The small framework icons should also be one color like they are on the cards so they are not confused with status shapes.

Page url: https://next.carbondesignsystem.com/libraries/carbon-charts/latest/assets/area-stacked

Small vanilla js shape icon

image

Large vanilla js icon

image

Small Svelte icon should be gray 70 just like small React icons

image

Same with Vue, should be solid gray 70 if we're doing that for React

image

Originally posted by @jeanservaas in https://github.com/carbon-design-system/carbon-platform/discussions/1268#discussioncomment-3684478

andreancardona commented 2 years ago

Hey team! Please add your planning poker estimate with Zenhub @alisonjoseph @francinelucca @jdharvey-ibm

jharvey10 commented 2 years ago

Is react the odd one out here? I feel like I remember us saying that we were going to stick with the color icons instead of making them grayscale. Maybe we should chat about this one?

alisonjoseph commented 2 years ago

~We should check with @jeanservaas~ I feel like we went back and forth on color vs. b&w icons and landed on b&w here, colored icons inside of resource cards.

actually nvm it was @jeanservaas who wrote this issue, so I think we're good to switch to b&w.

jharvey10 commented 2 years ago

IMO converting the yellow Javascript icon to instead just be "JS" is a downgrade because the page will then look like it says "JS Vanilla Javascript"; there's no distinguishing factor making it look an icon and differentiating it from the text next to it if it's just two grayscale letters. It's also a departure from the well-known yellow and black Javascript icon.

It seems like less work and a better end result if we just colorize the React icon so that the framework tags are all gray-70 and the inline icons on the asset details pages and library pages are all colorized.

@jeanservaas, @aubrey-oneal, @aagonzales What are your thoughts on that approach?

mattrosno commented 1 year ago

@carbon-design-system/carbon-platform-devs I removed from sprint 30 so it stops getting carried over.