carbon-design-system / carbon-platform

The "next" version of the Carbon Design System website, as a platform.
https://next.carbondesignsystem.com
Apache License 2.0
21 stars 5 forks source link

feat(mdx-components): add footer and common js for ibm compliance #1775

Closed alisonjoseph closed 8 months ago

alisonjoseph commented 9 months ago

Closes https://github.com/carbon-design-system/carbon/issues/15637 Closes https://github.com/carbon-design-system/carbon/issues/15652

Changelog

New

Testing / reviewing

run mdx-components storybook and verify footer is displaying correctly and common.js is being loaded

carbon-bot commented 9 months ago

The commits in this PR will result in the following version changes:

🌟 MINOR release: @carbon-platform/mdx-components

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

alisonjoseph commented 9 months ago

@jdharvey-ibm any idea why this is failing, does it matter for this storybook update? 😅

jharvey10 commented 9 months ago

@jdharvey-ibm any idea why this is failing, does it matter for this storybook update? 😅

@alisonjoseph LOL this is the age old "static build hit the GH rate limit" issue. But yeah, you're right that for the storybook update, we can safely ignore this.

andreancardona commented 8 months ago
Screenshot 2024-02-27 at 11 21 08
alisonjoseph commented 8 months ago

@jdharvey-ibm @francinelucca you ok with merging?

jharvey10 commented 8 months ago

@alisonjoseph Yeah! Go for it!