404 content needs vertical spacing - Githubissues

carbon-design-system / carbon-platform

The "next" version of the Carbon Design System website, as a platform.

https://next.carbondesignsystem.com

Apache License 2.0

21 stars 5 forks source link

404 content needs vertical spacing #1778

Closed mattrosno closed 8 months ago

mattrosno commented 8 months ago

Description

Tell us more about the problem that you're running into. What did you see? What did you expect to see?

We need to add some vertical spacing.

Steps to reproduce

How do we reproduce the error? Please be as specific as you can.

https://next.carbondesignsystem.com

Solution

Looking at this. Not sure what this declaration block is currently doing: https://github.com/carbon-design-system/carbon-platform/blob/main/services/web-app/components/page-not-found/page-not-found.module.scss#L17

I think we need 64px spacing on desktop:

And 32px spacing on phone: