carbon-design-system / carbon-platform

The "next" version of the Carbon Design System website, as a platform.
https://next.carbondesignsystem.com
Apache License 2.0
22 stars 5 forks source link

Add resource links to library detail page #578

Closed mattrosno closed 2 years ago

mattrosno commented 2 years ago

After talking with @aubrey-oneal - I confirmed that we don't need the body copy (D) in the design reference below for now.

Inheritance

Source

Package

Design ref

image

Internal code packages

We'll be indexing IBM Internal libraries that don't publish packages to npm. Instead, they often publish to artifactory or some other internal registry.

Looking at CloudPal for example, the package.json doesn't specify anywhere that it publishes to artifactory. If this package.json had private: true (as it should), then we know to not try to link out to npm. https://github.ibm.com/ibmcloud/pal/blob/master/patterns/package.json

mattrosno commented 2 years ago

Hey team! Please add your planning poker estimate with ZenHub @alisonjoseph @andreancardona @francinelucca @jdharvey-ibm

mattrosno commented 2 years ago

Make sure that we build this in a forward-looking way in case GitHub Registry gets used instead of npm.

kingtraceyj commented 2 years ago

Library redlines: https://ibm.box.com/s/s6btwm637udnek3pbjtfem412kgw83hp

mattrosno commented 2 years ago

After discussing with @francinelucca, link to npm if:

  1. Library has package.json
  2. package.json isn't private: true
  3. Use package.json name and version to construct an npm URL like: https://www.npmjs.com/package/@carbon/vue/v/2.44.0

We'll have a separate issue to discuss options for GitHub Packages and Artifactory for inner source code packages.

mattrosno commented 2 years ago

@francinelucca the post-v1 issue linked above so we can figure out those unknowns later.

mattrosno commented 2 years ago

@francinelucca re-opening to fix:

mattrosno commented 2 years ago

@francinelucca I fixed icon sizes here: https://github.com/carbon-design-system/carbon-platform/pull/891