search

carbon-design-system / carbon-platform

The "next" version of the Carbon Design System website, as a platform.
https://next.carbondesignsystem.com
Apache License 2.0
21 stars 5 forks source link

Translate straight quotes ( " and ' ) into “curly” quotes #721

Open alisonjoseph opened 2 years ago

alisonjoseph commented 2 years ago

https://github.com/silvenon/remark-smartypants

Smartypants automatically translates straight quotes ( " and ' ) into “curly” quote HTML entities

Consider doing this "in-house" if simple enough to not depend on a code package that hasn't received wide-spread adoption.

https://github.com/carbon-design-system/carbon-platform/issues/721#tasklist-block-d94dc1b8-24fb-4382-9615-6e0fa954881f

jharvey10 commented 2 years ago

Just checked out the package. A couple notes on it:

  1. The package has a very low amount of weekly downloads, which is concerning from a maintenance and battle-hardening perspective.
  2. This seems like something that should be handled by the markdown content developer themself; They should be using the appropriate text characters for their language and localization without us intervening.
mattrosno commented 2 years ago

"Test 123". I'm testing.

mattrosno commented 2 years ago

Hey team! Please add your planning poker estimate with ZenHub @alisonjoseph @andreancardona @francinelucca @jdharvey-ibm

francinelucca commented 1 year ago

Confirmed no sonarcloud alerts on the regex in https://github.com/silvenon/remark-smartypants/blob/master/index.js (what https://github.com/retextjs/retext-smartypants uses in the background) so we're good to move forward! image image