francinelucca
commented
2 years ago @jdharvey-ibm tagging you in case you want to add a better explanation to the packagejson error 😅
Open francinelucca opened 2 years ago
francinelucca
commented
2 years ago @jdharvey-ibm tagging you in case you want to add a better explanation to the packagejson error 😅
francinelucca
commented
2 years ago 12.2.0 now out
mattrosno
commented
1 year ago Hey team! Please add your planning poker estimate with ZenHub @alisonjoseph @andreancardona @francinelucca @jdharvey-ibm
mattrosno
commented
1 year ago @carbon-design-system/carbon-platform-devs I see the web app is now using Next ^12.3.2. It looks like we're no longer blocked to move scripts to a _document.js file if that's needed to close this issue.
Or, maybe we wait until Next 13 to take advantage of the new app directory?
https://beta.nextjs.org/docs/upgrade-guide#migrating-from-pages-to-app
francinelucca
commented
1 year ago I can take this and move the script so we can close this. Unless we want to hold off until we move to 13 and move to /app directory? It's currently in beta and they don't recommend using in production... CC: @jdharvey-ibm
https://beta.nextjs.org/docs/upgrade-guide#migrating-from-pages-to-app
mattrosno
commented
1 year ago Staying on 12 makes sense to me.
jdharvey-ibm
commented
1 year ago We definitely want to move to 13 soon since we have a dependabot PR now for that, but I agree that we can hold off with using the app folder for now. Should we use this issue to track the document.js changes as well as the effort to migrate to v13?
jdharvey-ibm
commented
1 year ago Could also close out this one and open a new issue to track the migration effort from 12 to 13.
jdharvey-ibm
commented
1 year ago https://nextjs.org/docs/upgrading
Actually looks like we're blocked there until Carbon supports React 18.
francinelucca
commented
1 year ago Worked on this a bit before EOY and was having trouble loading the script from _document.js , need to look further into it
Summary
We're waiting on next to release v12.1.7 so we can get some bug fixes in:
when this new version is released, let's upgrade and make the necessary changes and verify package.json error is no more
Job stories
What value will this deliver?
Acceptance criteria
What requirements must be met to complete this request?