search

carbon-design-system / carbon-platform

The "next" version of the Carbon Design System website, as a platform.
https://next.carbondesignsystem.com
Apache License 2.0
21 stars 5 forks source link

Add Percy for existing Storybook stories #887

Open alisonjoseph opened 2 years ago

alisonjoseph commented 2 years ago

Start with storybook, test each story in PR.

https://percy.io/dashboard https://percy.io/538fc19a/Carbon-Platform

https://docs.percy.io/docs/storybook

Estimated 10,000 snapshots per month to start #785 (46 stories x 50 PRs/month x 3 (account for commits to each PR after opening)

mattrosno commented 2 years ago

Is this to test Platform's private components (e.g. FrameworkIcon, CatalogItem, etc.)? Or to test Platform's public components (what we want ppl to use outside of Platform) for MDX? If it's the former too, then we'll need a separate issue to add those to Storybook? I don't think we have stories for all of our private components yet.

alisonjoseph commented 2 years ago

@mattrosno both, so you're correct, we need an issue to add our internal components / pages to storybook

mattrosno commented 2 years ago

Hey team! Please add your planning poker estimate with ZenHub @jdharvey-ibm @alisonjoseph