carbon-design-system / carbon-web-components

Carbon Design System variant on top of Web Components
https://web-components.carbondesignsystem.com/
Apache License 2.0
477 stars 80 forks source link

feat(link): add `icon-placement` option #1009

Open emyarod opened 2 years ago

emyarod commented 2 years ago

Related Ticket(s)

https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/8836

Description

This PR adds support for icon-placement in the link component to potentially deprecate the link-with-icon dotcom component

ibmdotcom-bot commented 2 years ago

Deploy preview created for Carbon Web Components: https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/1009/index.html

Built with commit: e7d8b6a047f44e6981a61f09516c023f1a99c2c4

ibmdotcom-bot commented 2 years ago

Deploy preview created for Carbon Web Components - Vue: https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/1009/index.html

Built with commit: e7d8b6a047f44e6981a61f09516c023f1a99c2c4

ibmdotcom-bot commented 2 years ago

Deploy preview created for Carbon Web Components - React: https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/1009/index.html

Built with commit: e7d8b6a047f44e6981a61f09516c023f1a99c2c4

ibmdotcom-bot commented 2 years ago

Deploy preview created for Carbon Web Components - Angular: https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/1009/index.html

Built with commit: e7d8b6a047f44e6981a61f09516c023f1a99c2c4

RichKummer commented 2 years ago

Agree with @ariellalgilmore on the knob update! I noticed that there seems to be some extra padding on the left when the icon is positioned on the left:

Positioned right

Screen Shot 2022-06-17 at 10 59 42 AM

Positioned left

Screen Shot 2022-06-17 at 10 59 28 AM

Not sure if this would cause downstream effects. Also Percy's picking up 72 differences, but it looks like these may just be new pages or Percy's creating this for the first time. Figured I would flag just in case:

Screen Shot 2022-06-17 at 10 54 51 AM
emyarod commented 2 years ago

@ariellalgilmore @RichKummer the knob should be on the Paired with icon story only now! also fixed the extra spacing when the icon is placed on the left side. and for the Percy changes, it looks like the snapshots are all brand new