carbon-design-system / carbon-web-components

Carbon Design System variant on top of Web Components
https://web-components.carbondesignsystem.com/
Apache License 2.0
477 stars 80 forks source link

fix(deps): downgrade mkdirp fixes storybook:react #983

Closed kennylam closed 2 years ago

kennylam commented 2 years ago

Description

This downgrades the mkdirp package. The previous upgrade of this package introduced breaking changes to the React Storybook environment, preventing it from loading.

Changelog

Changed

emyarod commented 2 years ago

reverts https://github.com/carbon-design-system/carbon-web-components/pull/864

kennylam commented 2 years ago

looks good to me! would we be able to go back to v0.5.5 or does it need to be on v0.5.0?

Oh good call, I didn't even notice the previous one had a patch version. Once it worked I was like commit! But I'll bump it back to the correct previous version.

ibmdotcom-bot commented 2 years ago

Deploy preview created for Carbon Web Components: https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/983/index.html

Built with commit: 0de2b728a011f5bedf1bea36dbaf0fc10067c389

ibmdotcom-bot commented 2 years ago

Deploy preview created for Carbon Web Components - Vue: https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/983/index.html

Built with commit: 0de2b728a011f5bedf1bea36dbaf0fc10067c389

ibmdotcom-bot commented 2 years ago

Deploy preview created for Carbon Web Components - React: https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/983/index.html

Built with commit: 0de2b728a011f5bedf1bea36dbaf0fc10067c389

ibmdotcom-bot commented 2 years ago

Deploy preview created for Carbon Web Components - Angular: https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/983/index.html

Built with commit: 0de2b728a011f5bedf1bea36dbaf0fc10067c389