search

carbon-design-system / carbon-website

The website for the Carbon Design System.
https://www.carbondesignsystem.com
Apache License 2.0
277 stars 771 forks source link

[Status indicators] Updating the naming convention of the status icons and shapes #2539

Open thyhmdo opened 3 years ago

thyhmdo commented 3 years ago

Lots of Status indicators icons have not been updated on our Icons page. Status indicators: https://www.carbondesignsystem.com/patterns/status-indicator-pattern/#shape-indicators

Missing icons:

High attention

Medium attention

Low attention

Status indicators

### Tasks
- [ ] Consider proposing new icon asset names to match pattern guidance (design) (*Note in issue: Make sure there is no overlap of new names for these icons that already exist for other icons in the system, if so we need to change those names as well.)
- [ ] Consider adding a column for the icon token names (svgs in the icon library)
tw15egan commented 3 years ago

Seems like part of the issue with incomplete is that we have both a 32 variant and a glyph variant, but they are completely different icons, causing issues

thyhmdo commented 2 years ago

https://github.com/carbon-design-system/carbon-website/issues/3310 Undefined icon needs to be updated

thyhmdo commented 2 years ago

turned out that we have most of status icons on the Icons page, but they're named differently. People may have difficulty finding icons due to naming. We also have extra icons, wondering if we need to clean them up or leave them as they are.

image

thyhmdo commented 2 years ago
image
thyhmdo commented 2 years ago

Icons that should be considered to be renamed / kept

Status icons

Shape icons

thyhmdo commented 1 year ago

Jeannie and I discussed this issue with Conrad. Here is what he said:

It’s not impossible to rename assets, it’s just that Github considers renamed assets net new so the old icon would effectively be “removed” and would have to be deprecated in favor of the renamed version even though there’s actually only a single file all along. So it’s totally doable to do a pass on certain icons and rename them. (edited) Someone on the Carbon team could make the changes in the Carbon repo easily enough without having to remove/add any of the files the only thing you’d have to be careful about is the fallout of products using the old name of icons especially since the status icons are so widely used (edited)

So the next step for us is to audit and strategically rename these icons again. However, we don't have the bandwidth to do this work. @sstrubberg Can you help us icebox this issue at the moment?

Meanwhile, I and Jeannie are going to create other issues related to Status indicators regarding the correct status colors and v11 tokens.

laurenmrice commented 2 months ago

@thyhmdo Will look at this issue to see if it has been resolved since it was created, or if there are still some action items to tackle.

tay1orjones commented 2 months ago

If there are icons that need to be renamed, we can only do that through a breaking change.

Also in some cases we may already have an icon with that name. For instance from above, warning hex would be renamed to warning alt, but we already have a warning alt

The only thing we've done without a breaking change is swap out the artwork under the same name.