carbon-design-system / carbon-website

The website for the Carbon Design System.
https://www.carbondesignsystem.com
Apache License 2.0
283 stars 789 forks source link

Implement VRT for website #3737

Open alisonjoseph opened 1 year ago

alisonjoseph commented 1 year ago

Baseline VRT

Only ~10 snapshots per PR build and would give us reasonable assurance we didn't totally break anything

tay1orjones commented 1 year ago

It's unlikely that we'll be able to do this without increasing our snapshot usage. I'd move to close this based on that.

tay1orjones commented 1 year ago

Since we reduced Percy usage by ~50% in https://github.com/carbon-design-system/carbon/issues/14779, I think we could do this but we'd need to be mindful of our quota.

tay1orjones commented 1 year ago

Instead of using playwright for taking and sending the percy snapshots, we could just invoke the percy cli and keep the usage as dead-simple as possible.