carbon-design-system / carbon-website

The website for the Carbon Design System.
https://www.carbondesignsystem.com
Apache License 2.0
278 stars 777 forks source link

Colors not matching with tokens when reading the style guide on Data Table #4140

Open sander-slagman opened 3 months ago

sander-slagman commented 3 months ago

Detailed description

In the style guide of the data table components, it says that $layer-selected-hover is used for when a selected row is hovered, however, $layer-hover is used.

Affected page: https://carbondesignsystem.com/components/data-table/style#row

Related page https://carbondesignsystem.com/elements/color/tokens (layer section)

Additional information

afbeelding

Not hovering: afbeelding

Hovering: afbeelding

e8e8e8 is used ($layer-hover ) and not #cacaca ($layer-selected-hover )

laurenmrice commented 3 months ago

@sander-slagman Are the two screenshots you provided for "Not hovering" and "Hovering" coming from the React storybook?

sander-slagman commented 3 months ago

Hi Lauren, Sorry for the late response, thought I had already replied. No they are coming from the official design system documentation, the related links are the source pages. Hope this helps

sander-slagman commented 3 months ago

For some additional info, inspector tells me that the token --cds-layer-hover somehow overwrites the --cds-layer-selected-hover afbeelding