Closed laurenmrice closed 1 month ago
vercel[bot]
commented
2 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| carbondesignsystem | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 11, 2024 8:21pm |
laurenmrice
commented
2 months ago Need dev help
Cli format and Vercel preview are both failing. I tried to use the command you gave in slack and ran yarn format but no luck.
Usage tab:
Feature flag above the page description like below:
Code tab:
Feature flag in the React resource card like below:
aagonzales
commented
1 month ago @Kritvi-bhatia17 @laurenmrice I'm also concerned about the tabbed then stacked images we have going on here. Especially in the interactive state section, its a lot of scrolling and the context kind of gets lost in there. Would it be weird to tab the background modifier image as well? Just to help consolidate things?
Another approach I was thinking of was to just move all the "background modifier" color section into on h3 color section
These are just thoughts ... we can always come back to this later. We don't need to block this PR while we think on this. This is one of the more tricky Style sequences I've seen.
laurenmrice
commented
1 month ago @aagonzales Yeah, this part has been really tricky to deal with and I agree it currently looks strange. I will try one of those suggestions out. I think I like the separate H3 section instead of adding a third tab.
laurenmrice
commented
1 month ago I see it! I am fixing it before it merges in. Thank you!
Closes #4224
This PR updates the Structured list component Usage, Style, and Code tabs to include feature flag information and images. The content on the Usage and Style tabs have also been updated with the new content templates.
Note: Links in various places to the "Feature Flag tab" have not been updated yet, because that page is not live yet.
Changelog
New
Usage:
Style:
Code:
Changed
Removed