search

carbon-design-system / carbon-website

The website for the Carbon Design System.
https://www.carbondesignsystem.com
Apache License 2.0
283 stars 785 forks source link

docs (notifications a11y): update to new template #4270

Closed benjamin-kurien closed 1 week ago

benjamin-kurien commented 2 months ago

Closes #4253

Accessibility document for notification, updated to follow the new template.

Changelog

New

Changed

Removed

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 2:24pm
mbgower commented 1 month ago

@benjamin-kurien as I mentioned on a prior call, the accessibility content is normally built to complement information already provided in the Usage and Style tabs; however, when I look at the deployment preview, there is no occurrence of the word "Callout" on either of these pages. The only place it is covered is the a11y tab. Is that just a result of those changes being in a separate PR? If so, please provide, as it is hard to review this material without knowing what the user has already been told about Callouts on other tabs.

benjamin-kurien commented 1 month ago

@benjamin-kurien as I mentioned on a prior call, the accessibility content is normally built to complement information already provided in the Usage and Style tabs; however, when I look at the deployment preview, there is no occurrence of the word "Callout" on either of these pages. The only place it is covered is the a11y tab. Is that just a result of those changes being in a separate PR? If so, please provide, as it is hard to review this material without knowing what the user has already been told about Callouts on other tabs.

Hi @mbgower Here's a link to the PR that documents the usage and style guidance for Callout

mbgower commented 1 month ago

@benjamin-kurien Here are some comments. I recommend downloading and opening with Acrobat Reader to more easily review. Notification – Carbon Design System.pdf

mbgower commented 1 month ago

My apologies for not just putting these comments inline in the PR!

benjamin-kurien commented 1 month ago

Hi @mbgower. I have updated the PR with the changes you requested. Please review