Checkbox: v11 audit

[aagonzales]

Audit

A designer and developer will pair on this audit, some tasks may be discipline focused. Follow the checklist below for the features and items to review. If there are no issues with the item then check the item as complete. If any problems or bugs come up when auditing add a comment to this issue with the problem and how to correct it (if you know how). Bugs do not need to be fixed while auditing.

Resources

• Design spec in Sketch
• V11 Website
• SCSS
• Storybook

Variants

• Single line
• Multi-line
• Inline

Checklist

Visual (in React code) Design and dev check

• [x] Component is using the correct design tokens (color and type), see design spec and scss code.
• [x] Component is rendering correctly across themes and layers, see design spec and storybook.
  • [x] White theme
  • [x] Gray 10 theme
  • [x] Gray 90 theme
  • [x] Gray 100 theme
• [x] Component is rendering correctly across browsers (check themes across browsers as well), see storybook.
  • [x] Firefox
  • [x] Safari
  • [x] Chrome

• [x] ~Component sizes are rendering and named correctly (if applicable)~ NA

  Website (v11) Design checks

• [x] Style tab has correct design tokens listed
• [x] ~Style and usage tabs are using the correct size props names (if applicable)~ NA
• [x] Usage tab is up-to-date for with any v11 behavioral changes (if any)
• Live Demo has applied v11 changes
  • Themes are rendering correctly
  • [x] ~Size props are named correctly~ NA
  • [x] No light props included

Design Kits (Sketch only) Design checks

• [x] Correct design tokens (type and color) are used
• [x] ~Component using the correct size prop names~ NA
• [x] ~Any additional v11 behaviors have been added~ NA

Storybook Dev checks

• [x] Confirm that prop table is populating
• [x] Take note of missing examples/stories (if any)

React package Dev checks

• [x] Go to https://codesandbox.io/s/github/carbon-design-system/carbon/tree/main/packages/react/examples/codesandbox and confirm that you can use the component as expected from @carbon/react

Accessibility Dev checks

• [x] Confirm that there are no violations in Accessibility checker
• [x] Confirm that component works as expected with VoiceOver

Migration docs Design and dev check

• [x] Any breaking changes to this component are present in the v11 migration guide.
  • [x] Design
  • [x] Develop

[laurenmrice]

Visual bugs

scss code

• [x] Type token for checkbox-label is still using a v10 token name. It should be $body-compact-01.
• [x] Check to make sure all spacing tokens use the format $spacing- instead of having to prefix the token with $carbon--.

[laurenmrice]

Website

Style tab

• [x] Color/Checkbox:checked:checkmark = $icon-inverse

Live demo *Updating the Live demo with our current code should fix most of these bugs.

• [ ] Modifiers: Need to add a "checked" state modifier.
• [ ] Themes: The disabled checkbox group label and labels need to be color token $text-disabled.

[laurenmrice]

Design kit

• [x] Checked icon inner fill should be color token $icon-inverse.
• [x] Indeterminate icon Inner fill should be color token $icon-inverse.
• [x] Disabled state icons should be color token $icon-disabled.

[tw15egan]

Went through the dev checks and it looks good on my end 👍🏻

[aagonzales]

Closing as this all looks complete now. Live demo edits will be track in https://github.com/carbon-design-system/carbon/issues/10889