Plex is not up to date, package is too large

carbon-design-system / carbon

A design system built by IBM

https://www.carbondesignsystem.com

Apache License 2.0

7.61k stars 1.76k forks source link

Plex is not up to date, package is too large #11661

Open tay1orjones opened 2 years ago

tay1orjones commented 2 years ago

We're working to update how Plex is published - https://github.com/IBM/plex/discussions/452. It's likely Plex will start to publish individual packages per-family.

Currently we're blocked by this. The compressed package binary is too large, https://github.com/IBM/plex/issues/453. Once this has been addressed, we need to update packages:

Checklist

[ ] Update Plex package(s) and versions
[ ] Determine how we would need to revise the sass font resolver, and then update it
[ ] Ensure no regressions
[ ] Put together an e2e/percy snapshot for the Plex families Carbon includes (nice to have)

Workaround

To use the most up to date Plex assets with Carbon, you can configure the sass to use the Akamai server. It can be configured via the $use-akamai-cdn scss config variable.

mjabbink commented 1 year ago

@tay1orjones @alisonjoseph Making the note here that the “ﬁ” ligature should be the default setting. Whatever Carbon for IBM.com is doing and what Carbon did with v10 is the correct expectation.

sstrubberg commented 1 year ago

@tay1orjones can you remind me where we're at with this? Is this the one we're moving to Brand?

tay1orjones commented 12 months ago

@sstrubberg This issue is for the work we need to do in this carbon repo, no matter who updates the Plex repo. We can't do this work until the Plex repo is updated and publishes an npm package for each Plex font family.

tay1orjones commented 2 weeks ago

Plex has been coverted to a monorepo, https://github.com/IBM/plex/pull/577, and is now publishing a collection of per-family packages. These packages should be individually small enough to work around this issue.

I think the steps to complete this are:

[ ] Remove @ibm/plex from @carbon/styles, and add the new per-family packages
[ ] Update the renovate config to always batch together updates to these dependencies
[ ] Update the default font resolver to work with the new packages and directory structure.
[ ] Figure out what to do with $font-path - can we support consumers' existing pathing structure while also enabling the new per-family pathing?
[ ] Update docs on all this, perhaps even add docs on what/why this change is so consumers can understand the situation
[ ] ...
[ ] Once the Plex Akamai CDN has been updated to this new pathing we'll also need to update that portion of the default font resolver