Experimental Component: Primary Link — Development (Focus state revision)

carbon-design-system / carbon

A design system built by IBM

https://www.carbondesignsystem.com

Apache License 2.0

7.86k stars 1.81k forks source link

Experimental Component: Primary Link — Development (Focus state revision) #1263

Closed jeanservaas closed 5 years ago

jeanservaas commented 6 years ago

Digital / Brand Teams noticed problems with the focus state of the Primary Link. It was previously and underline that was causing problems for them if the link was breaking to two lines.

They redesigned the focus state to fix. See attached.

https://app.zenhub.com/files/84835535/3283db76-c104-4513-82d0-185c0b70507b/download

joshblack commented 6 years ago

@jeanservaas are they sure they want this as the focus state? As a heads up, it will appear when a user is interacting with the link, not just with keyboard focus. So any time they click on it this box will appear.

jeanservaas commented 6 years ago

@joshblack @aagonzales Let's hold on this and discuss Monday... we have a few other things to hash out Monday morning too. I want to ask Erica more about the change and I want to run it by Anna.

ps, are you talking about Chrome when you say this "...it will appear when a user is interacting with the link, not just with keyboard focus." ?

jeanservaas commented 6 years ago

FYI this focus state change would also affect Breadcrumb

jeanservaas commented 6 years ago

@joshblack -- is this issue just a Northstar (Drupal) thing? If so maybe it won't affect us... and then we won't need this update. Can we double check this with them?

joshblack commented 6 years ago

@jeanservaas just wanted to note that when we say focus indicators that they will appear when someone uses a keyboard or mouse to interact with the component.

Example link: https://codepen.io/joshblack/full/aREqaw

If you press tab the outline will appear, in addition to when you click it.

aagonzales commented 6 years ago

I think we all agree the underline is a better solution but it sounded like Northstar was having some technical difficulties with the style which is why they changed it. We just changed it to stay consistent. @joshblack were you running into any issues with it (the underlined version). Or would you know what could be their problem?

joshblack commented 6 years ago

Definitely no issues! Just wanted to make sure folks were aware 👍

jeanservaas commented 6 years ago

@joshblack @aagonzales Apparently it's not a Drupal thing. Here's the issue from the Digital team about the focus state: https://github.ibm.com/webstandards/digital-design/issues/48

Scroll down to this comment by @santelia on Aug 24: