search

carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.81k stars 1.8k forks source link

Table batch action bar confusing to close / clear #13859

Closed heinsj closed 1 year ago

heinsj commented 1 year ago

Detailed description

We have received feedback from multiple users that the "Cancel" action on the table batch action bar is confusing them.

When interacting with the table, if the user checks a box next to an item the batch action bar opens. In order to dismiss the batch action bar the user must deselect items or click Cancel. The word "Cancel" has caused confusion with users because either they have not taken an action yet and there is nothing to cancel or they have taken an action and are afraid that "Cancel" will undo the action they just took.

What version of the Carbon Design System Kit are you using? V10 but applies to future as well

Is this issue related to a specific component? If so please give the page, artboard, and layer/symbol name. Table

What did you expect to happen? What happened instead? What would you like to see changed? After reviewing this with many other designers in Sustainability Software, the consensus is that "Cancel" can be changed to "Close" and that is far more clear and a simple change. Using the word "Clear" was also discussed and found that "Clear" could also be interpreted wrong. "Close" was the preferred update.

Is this issue being filed based on a discrepancy between the website/code and the kit? If so what is the inconsistency?

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

IBM Engineering - we are seeking to correct in our toolkit but it would be best to get this done at the Carbon level too so that all teams can benefit.

Steps to reproduce the issue

  1. Go to a table that allows selection of multiple rows.
  2. Click the checkbox for one or more rows.
  3. Observe the batch action bar opens.
  4. Observe the action to close the batch action bar is "Cancel" but there is nothing to cancel.

Additional information

image

Add labels

Please choose the appropriate label(s) from our existing label list to ensure that your issue is properly categorized (i.e.use the libraries label for any issue relating to the Carbon Sketch Library). This will help us to better understand and address your issue.

tw15egan commented 1 year ago

This text can currently be modified with the translateWithId prop passed into TableBatchActions. 

const translationKeys = {
  'carbon.table.batch.cancel': 'Cancel',
  'carbon.table.batch.items.selected': 'items selected',
  'carbon.table.batch.item.selected': 'item selected',
};

https://github.com/carbon-design-system/carbon/blob/main/packages/react/docs/g11n.md