carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.88k stars 1.82k forks source link

[Bug]: DataTable Expansion - weird styling bug #14036

Open andreancardona opened 1 year ago

andreancardona commented 1 year ago

Package

@carbon/react

Browser

No response

Package version

carbon/react@1.31.0

React version

No response

Description

DataTable Expansion has a weird 1px border in the bottom left hand corner - particularly noticeable when you expend the the row

Reproduction/example

https://react.carbondesignsystem.com/?path=/story/components-datatable-expansion--default

Steps to reproduce

https://github.com/carbon-design-system/carbon/assets/32720851/5146c5bb-7487-4df2-8778-d53b224d1fc2

Suggested Severity

None

Application/PAL

No response

Code of Conduct

tongyy commented 1 year ago

this is caused by this fix. I removed it and tested those existing stories. it looks good. Not sure how to reproduce the expaned parent separating border issue.

_data-table-expandable.scss

  // fix expanded parent separating border length
  tr.#{$prefix}--parent-row.#{$prefix}--expandable-row
    td.#{$prefix}--table-expand
    + td::after {
    position: absolute;
    bottom: rem(-1px);
    left: 0;
    width: rem(8px);
    height: rem(1px);
    background: $layer-accent;
    content: '';
  }