carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.73k stars 1.79k forks source link

Remove placeholder text from Dropdown/Multiselect fields #14308

Open laurenmrice opened 1 year ago

laurenmrice commented 1 year ago

After discussions with Accessibility we have decided to remove current placeholder text from the fields of Dropdown and Multiselect. However, the Multiselect and Filterable Multiselect selected states can still provide text in the field along with the number tag to help inform the user that options(s) are selected.

When we discussed this in the CAG call, there was potential dev concern around if this would be a breaking change for the end user if they were currently placeholder text in product for these components. It was mentioned that we could think about having a deprecation warning for placeholder text in dropdown and multiselect for a few releases if it makese sense to. For reference, we previously did this same change to the Select component #13008 and I know in the past we did this with Combobox and Filterable Multiselect.

Ref a11y issue: #3363


Design Spec

Frame 2

Code of Conduct

tay1orjones commented 1 year ago

So the previous scope of this for Select was to just remove the placeholder text from the storybook stories, which is what we could start with here. Removing the actual prop for placeholder text would be a breaking change that we can't do right now.

thyhmdo commented 4 months ago

Just to document a few comments from @aubrey-oneal and @lesnider


Aubrey: I like having the helper text say 'select a fruit' so that it's clear they haven't made a choice yet. To avoid redundancy it then makes sense for the title to say Fruit. I do prefer the grayed out helper text but I see that it is 'outdated'. Is this an accessibility concern?


Laura:


An image for reference

default