carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.8k stars 1.8k forks source link

[Dev] Data Table Implementation (Overflow menu) #15480

Closed Kritvi-bhatia closed 6 months ago

Kritvi-bhatia commented 9 months ago

"By default, the overflow menu icons are persistent on each row. Having the overflow menus always visible signals to the user actions can be taken on the table rows. Alternatively, a product team may use the overflowMenuOnHover prop to only show the overflow menu on hover and focus to reduce the visual clutter of an overflow menu on every row" Source

TO BE UPDATED : In the storybook, by default state should be the menu icons are persistent on each row.

Currently, we can add this under feature flag.

CURRENT STATE : Currently, we're having the over flow menu hover state as by default.

image

References:

github-actions[bot] commented 9 months ago

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

tay1orjones commented 9 months ago

@Kritvi-bhatia This can currently be done with the overflowMenuOnHover prop. Here's an example, you can configure the controls to toggle the prop.

I think we can close this issue unless we want to mandate this change to always be visible. If we want it to be a configurable option like it already is, I think we can close this one.

tay1orjones commented 9 months ago

After discussing further, the determination is this will just be changing overflowMenuOnHover to be false by default. It's already mentioned on the website to be this way, so this unifies the implementation against the current documentation. This isn't new design guidance either, it's been present for quite a while on the website.

We think this does not constitute a breaking change because:

Kritvi-bhatia commented 9 months ago

HI @tay1orjones, can you please help me understand what is this "persistent" boolean is for? image

guidari commented 8 months ago

Hey @Kritvi-bhatia17 The persistent prop makes the search functionality not expandable and persistent.

Example: https://react.carbondesignsystem.com/?path=/story/components-datatable-toolbar--persistent-toolbar

mranjana commented 7 months ago

hi @guidari , Can i work on this?

guidari commented 7 months ago

Sure @mranjana I'll assign you!