carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.86k stars 1.82k forks source link

[Feature Request]: TableBatchActions should allow dropdown and tooltips #15602

Open dabrad26 opened 9 months ago

dabrad26 commented 9 months ago

The problem

Batch actions (blue bar) for tables is clipping and causes issues with items rendering absolute or other content outside of the bar. Making this bar not use clip or other wrappers would be nice. And maybe also supporting a built in More option where the bar renders what it can and moves rest into a more to avoid overflow or page breaking layouts.

The solution

Provide way to load items with content that lives outside of the bar and maybe also add more support.

Examples

Products pal: https://pages.github.ibm.com/cdai-design/pal/components/data-table/batchactions/usage/#more-than-4-actions

Sustainability pal: https://pages.github.ibm.com/ai-applications/design/components/datatable/rowactions/#batch-action-overflow

Application/PAL

Aspera

Business priority

Medium Priority = upcoming release but is not pressing

Available extra resources

No response

Code of Conduct

github-actions[bot] commented 9 months ago

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

tay1orjones commented 9 months ago

My 2 cents is I do think it's worthwhile we look at this again from a design and UX perspective. I don't think we'd want to recommend using an OverflowMenu to contain overflow items, because those items could themselves be an OverflowMenu, Dropdown, Button w/ a tooltip, etc.

It might make sense to consider if the "overflow" items should be housed in a Popover instead, and as the width of the action bar grows/shrinks items would be removed/added to the Popover, respectively.

In any case, I personally think this feature should be supported formally, similar to how we added support for Breadcrumb with OverflowMenu. Multiple PAL libraries have implemented something similar. We could confer with them on their implementations to see if there's an opportunity to deduplicate some components out in the PALs to be in the core component. At the very least, the clip styling of the toolbar could be removed or be able to be turned off so teams like yours can more readily implement things like this without fear of future updates to styling breaking things.