search

carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.6k stars 1.76k forks source link

[Question]: Should Radio button fix has been released? #15992

Open BenceLovas opened 3 months ago

BenceLovas commented 3 months ago

Question for Carbon

Hi, I've opened an issue about the radio button component. https://github.com/carbon-design-system/carbon/issues/15894 It has been fixed, and based on the commit history, it should have been released in 1.53.0, but neither I can see it in the release notes, nor it works when I update the library. I might guessed it wrong by assuming that every commit gets released. So, has it been released?

Code of Conduct

tay1orjones commented 3 months ago

@BenceLovas Based on the info on the page for the merge commit, that commit was first made available in v1.53.0-rc.0. This means it was also included in everything after: 1.53.0, and the patch we just cut, 1.53.1.

image

Viewing the published package on unpkg I can see that it's there (search for print-color-adjust)

Could you reproduce the issue in a stackblitz showing how it's not working, and post the link back here? It's hard to know exactly what's going wrong without seeing the issue firsthand.

BenceLovas commented 3 months ago

@tay1orjones My original issue was about the Radio Button component, but it also has the print-color-adjust added to the scss file.

The issue was (and still is) that the selected radio button has not been shown on the print preview (⌘ Command + P), hence the saved pdf won't have it either. (I'm not sure if this applies to the Checkbox component as well, haven't tested that.)

Reproduction: https://codesandbox.io/p/devbox/goofy-liskov-2ljg99?file=%2Fsrc%2FExample%2FExample.jsx%3A11%2C19 If you open print preview (it's a bit cluttered in this case), you can see that the radio button selection is not reflected (all circles are empty).

tay1orjones commented 3 months ago

It looks like that's isolated to the codesandbox environment. They're showing in the story

image
BenceLovas commented 3 months ago

@tay1orjones It's weird, you're right it's showing up on your Storybook, but I tried it on Stackblitz as well and it was not woking: https://stackblitz.com/edit/vitejs-vite-6byqqw?file=src%2FApp.scss,src%2FApp.jsx&terminal=dev I also tried it in two separate React projects and it wasn't working either. Can it be that your Storybook example is somehow differs from what I was reproducing?

guidari commented 3 months ago

Yeah. And it is only happening in Chrome. I tested on FF and Safari and it works as expected