carbon-design-system / carbon

A design system built by IBM

https://www.carbondesignsystem.com

Apache License 2.0

7.87k stars 1.82k forks source link

Storybook footer display issue on mobile #16053

Open alisonjoseph opened 8 months ago

alisonjoseph commented 8 months ago

STATUS: Ready for dev next sprint (97)

Acceptance criteria

The height of the footer on mobile screens makes the storybook almost unusable. We are currently using the dot com footer component.

Design

[ ] Need a recommendation from design, and then will need to apply the update to all public storybooks. (charts, v7 storybook, ibm products, dot com, webcomponents)

Playback

[ ] Playback to team to decide on which design spec to build.

tay1orjones commented 3 months ago

Could we do something like cloud where we move these links to somewhere else in the UI? They put the privacy link in a uishell dropdown.

When you click it, it opens a modal with the cookie prefs

This way they avoid any footer on the page. Storybook is a bit different than a typical ibm.com page because it's essentially a single page app at 100% x 100% with no ability to scroll the footer out of the way

tay1orjones commented 1 month ago

Two options discussed today

add links to sidebar, https://github.com/storybookjs/storybook/issues/8047
add links to a new dropdown in the story header bar, like the locale dropdown

aagonzales commented 4 weeks ago

@alisonjoseph @tay1orjones Do the links need to be persistent? If not, could we just have the footer on the Welcome page and then not have it show up on other pages?

If that's not possible, we should just add the links to the bottom of the left nav. That seems like more of a natural spot than in the header bar.

alisonjoseph commented 3 weeks ago

@aagonzales They need to be on all pages, I agree bottom of the left nav probably makes the most sense.

I believe its just the Privacy and cookie preferences links that we need, not the entire list of links in the footer.

aagonzales commented 3 weeks ago

If we can add icons to the right side of the header than could work too, I just don't think it fits in with the content on the left side of the header.

Or the bottom of the left nav if you can get external links to work there

aagonzales commented 1 week ago

I think this issue is ready to go to the dev next sprint. We should try to see which of those two versions is possible in Storybook.