search

carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.52k stars 1.75k forks source link

Export typescript props for TabProps #16380

Closed riddhybansal closed 1 week ago

riddhybansal commented 3 weeks ago

linking issue for #16154

Gururajj77 commented 2 weeks ago

closed as this is completed previously.

kenneth-nguyen1 commented 2 weeks ago

Hi @Gururajj77, where was this task completed?

I do not see TabProps (https://github.com/carbon-design-system/carbon/blob/main/packages/react/src/components/Tabs/Tabs.tsx#L739) being imported and exported from /components/Tabs/index.tsx nor /components/Tab/index.tsx on the carbon main branch and can't find an open or closed PR for this being completed.

Gururajj77 commented 2 weeks ago

Thank you, @kenneth-nguyen1, for pointing that out! I appreciate your attention to detail. I'll make sure to export TabProps as well. Initially, I had excluded the component since TabsProps was already being exported. Your feedback is very helpful!

kenneth-nguyen1 commented 2 weeks ago

Thank you, much appreciated!

Gururajj77 commented 2 weeks ago

Hey @kenneth-nguyen1 , have added export for TabProps now, you can track the progress on this PR, #16448.

Gururajj77 commented 1 week ago

closed with #16448