search

carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.8k stars 1.8k forks source link

[Bug]: DropdownSkeleton missing helper text and caret #16430

Open alisonjoseph opened 4 months ago

alisonjoseph commented 4 months ago

Package

@carbon/react

Package version

v11

React version

1.57.0

Description

DropdownSkeleton in React is missing an option for helper text, it also doesn't display the caret icon. (need to confirm with @carbon-design-system/design if this is a bug in code or in Figma)

React

Screenshot 2024-05-10 at 7 54 26 AM

Figma Screenshot 2024-05-10 at 7 53 25 AM

Reproduction/example

https://react.carbondesignsystem.com/?path=/story/components-dropdown--skeleton

Steps to reproduce

Compare Figma to React

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

No response

Code of Conduct

laurenmrice commented 4 months ago

I think design needs to do an audit of our skeleton state specs for all components that have them to try to make them more consistent. I believe we may be moving away from including the icons in the skeleton state, so the code is probably more accurate for now.

alisonjoseph commented 4 months ago

@laurenmrice makes sense. Do we want to add the helper text option to this skeleton state in code?