carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.6k stars 1.76k forks source link

Figma Carbon coverage plugin design exploration II #16832

Open RichKummer opened 2 weeks ago

RichKummer commented 2 weeks ago

Figma design exploration

Prototype logic breakdown

This exploration phase will focus on refining the different options within the assistant flow.

Some refinement considerations:

### Tasks
- [ ] Explore Figma plugin Preact component library
- [ ] Identify Figma plugin Preact components that could be used
- [ ] Prepare for WatsonX challenge workstream
- [ ] Refine design explorations, focusing on assistant flows
- [x] Connect with Accessibility checker team to refine and collect feedback
- [x] Continue research of related experiences
- [x] Research into prototype logic

Follow up tasks:

RichKummer commented 1 week ago

Plugin non-Carbon highlight logic:

Based on current prototype code: https://github.com/theiliad/carbon-figma-lint-plugin/blob/main/src/main.ts#L42

Messages:

  1. Overridden [Carbon] instance. Please reset changes
  2. Instance is not a [Carbon] instance
  3. Text is not using Carbon (if text style is mixed in a single text element)
  4. Text Style is not from Carbon (if text is not mixed like above, but is still not Carbon).
  5. Text Color style should only use surface/text or feedback/text tokens (checks text color styles and if they are not Carbon, triggers this message)
  6. Use a Divider Component Instead
  7. Effects not from Carbon's elevation styles
  8. Box border color should only use surface/border/* tokens
  9. Box not adhering to [Carbon] guidelines (shows up if element is not an image and doesn't have fill or stroke).
  10. Use relevant Carbon component (checks this logic: Boolean(hasStrokes || hasEffects || hasFills) && !Boolean(traversedNode.fills === figma.mixed)
  11. Not created using Carbon Components/Tokens (unclear, checks if node is not one of these types in the array, and then if its parent is not a page)

Image

Could we check for v10 components and provide a focused message to swap to v11?

RichKummer commented 1 week ago

Access checker feedback 06/28/24

Jess Lin & Tom Brunet

Carbon coverage plugin

Access checker